Skip to content

Comments

fix: use strict equality checks for vote count and minId logic in Ran…#510

Merged
zeng407 merged 1 commit intomasterfrom
develop
Feb 5, 2026
Merged

fix: use strict equality checks for vote count and minId logic in Ran…#510
zeng407 merged 1 commit intomasterfrom
develop

Conversation

@zeng407
Copy link
Owner

@zeng407 zeng407 commented Feb 5, 2026

…kReportHistoryBuilder

Copilot AI review requested due to automatic review settings February 5, 2026 07:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves code quality by replacing loose equality operators with strict equality operators and removing redundant conditional logic in the RankReportHistoryBuilder class.

Changes:

  • Replace loose equality (==) with strict equality (===) for vote count and minId comparisons to ensure type-safe comparisons
  • Remove redundant if-else block that had duplicate code in both branches

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zeng407 zeng407 merged commit d912a8e into master Feb 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant