Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

fix PHP 7.2 issue and update the build matrix #83

Merged
merged 1 commit into from
Dec 13, 2017
Merged

Conversation

lsmith77
Copy link
Contributor

@lsmith77 lsmith77 commented Dec 1, 2017

minor PHP 7.2 fix .. also updated the build matrix for PHP versions that are not EOL.
not sure if ZendFramework supports even older versions ..

I also updated the dependencies to stable versions. However there might be some new major versions that should also be allowed.

Once this is merged I guess we will tag 1.1.0?

@cordoval
Copy link

cordoval commented Dec 5, 2017

you were 4 days ahead of me 😊

@lsmith77 lsmith77 requested review from Thinkscape and removed request for Thinkscape December 8, 2017 10:26
@lsmith77
Copy link
Contributor Author

ping @Thinkscape :)

Copy link
Member

@Thinkscape Thinkscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're awesome

@Thinkscape Thinkscape merged commit d27aa06 into master Dec 13, 2017
@Thinkscape
Copy link
Member

@Thinkscape Thinkscape deleted the php7_2_fix branch December 13, 2017 08:39
@lsmith77
Copy link
Contributor Author

too kind :)

thx for the release!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants