This repository was archived by the owner on Jan 31, 2020. It is now read-only.
fixed connectionUri for mongo checker #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
tkachuk
force-pushed
the
hotfix/fixed_mongochecker_connectionUri
branch
5 times, most recently
from
fdf3532 to
ebc2370
Compare
|
lets merge #83 first .. and then rebase this PR and hopefully it will be all green :) |
|
What about this pull request? |
|
can you rebase on master? |
- Adds a test in `ChecksTest` for testing mongo functionality.
- Adds an env variable to `phpunit.xml.dist`, disabling mongo tests by default.
- In `travis.yml`:
- Enable mongo tests
- For PHP 5.6 versions, set a `MONGO_LEGACY` env variable. When this
is present, use the `mongo` extension; otherwise the `mongodb`
extension.
- For PHP 7 versions, require the `mongodb/mongodb` package.
weierophinney
force-pushed
the
hotfix/fixed_mongochecker_connectionUri
branch
from
ebc2370 to
23b38b3
Compare
weierophinney
added a commit
that referenced
this pull request
Jun 25, 2018
weierophinney
added a commit
that referenced
this pull request
Jun 25, 2018
|
Thanks, @tkachuk! I rebased off of master, and added unit tests so we can verify the functionality going forward. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.