Closed
Conversation
Yanis002
commented
Oct 18, 2025
src/emulator/xlCoreRVL.c
Outdated
| case VI_MPAL: | ||
| case VI_EURGB60: | ||
| rmode = &GXPal528IntDf; | ||
| #if !IS_MK64 |
Collaborator
Author
There was a problem hiding this comment.
I don't like this (#if !IS_MK64) but idk how to do it properly, the intent here is saying "if version >= OoT"
maybe I should reorder the version numbers so I can do #if VERSION >= OOT_J or something
Collaborator
Author
There was a problem hiding this comment.
I think this is better now
Collaborator
Author
|
closing in favor of #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds splits and symbols for each MK64 regions (except the korean version since it was released a year or two after OoT), also I renamed
oot-vctowii-vcto make it more generic. Also I tried to match everything I could, currently the progress is even with OoT except for the non-matching files for OoTMain focus still is OoT but doesn't hurt to look at the other versions too, also it will highlight the evolution of the codebase