Repository navigation
fix(electron): restore the startup splash and launcher build checks - #73
Draft
zedarvates wants to merge 1 commit into
Draft
zedarvates wants to merge 1 commit into
zedarvates wants to merge 1 commit into
Conversation
|
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The launcher cannot compile because
electron/main.tsimports and instantiates an unversionedSplashWindow. Restore the existing startup-status contract so the rootnpm run electron:buildsucceeds.--no-sandboxonly for CI; it does not establish runtime sandbox enforcement.config/package.jsonremains a legacy snapshot with stale relative paths.Local validation on Node 24.19.0 / npm 11.9.0:
npm ci --ignore-scripts --no-audit --no-fund, 13 splash tests,npm run electron:buildandgit diff --checkpass. Before this patch, the same build fails with TS2307 for./SplashWindow.Follow-up to the build blocker documented in reviews of #70 and #63. This PR changes no dependency versions and merges neither dependency PR. Current-head Actions/Sonar evidence must be checked after publication.
Scope limits: no complete-app startup, Creative Studio renderer, live provider/backend, packaging or macOS/Windows acceptance is claimed. Creative Studio has its own existing Vite and TypeScript failures; this patch does not waive them.
Current-head evidence — 2026-10-03
Electron Launcher CI run 37132545155 is successful on
3a8cac25a11ed207192d443562f899cecb54aede. Both Node 22.12.0 and 24.19.0 jobs passed installation, all 13 tests and compilation. The Linux splash-smoke job passed on Electron 41.10.3, embedded Node 24.18.0, including document load, buffered/latest progress updates, literal markup text, no rendererrequire, and native-window closure. Xvfb/--no-sandboxlimits still apply; this is not full-application or sandbox-enforcement evidence.Local integration: apply exact #63
ca5b890a4fe010065a76294506abbde0b293ec3cto exact #7099feb3319e35a896bbdb4505a02a9fa452380329, then this patch. Rootnpm ci --ignore-scripts --no-audit --no-fund, all 13 tests andnpm run electron:buildpass with Electron 41.10.6 / patched Axios and Undici. This local combination is not the head of either dependency PR.SonarCloud analysis 111231455295 is successful on the same head. The green gate does not establish full-app/runtime security acceptance or closure of every alert.