Repository navigation
fix(studio): restore grid renderer data and redraw contracts - #79
Draft
zedarvates wants to merge 2 commits into
Draft
zedarvates wants to merge 2 commits into
zedarvates wants to merge 2 commits into
Conversation
|
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



GridRenderer and PanelRenderer lost their concrete data types and disagreed on basic panel output. Restore the existing Layer/Panel/crop/annotation contracts, remove the LegacyAny URL assertions, and fix the reproduced redraw and composition defects.
Partial follow-up to #74, draft stacked on #78 at
af83b71145191bb964f2109261adbe15234cdd87. Current head:e51f631d4215c8f2e1c925d3e57a38fb4999596a. Dependency versions/locks and full application compiler flags/source inclusions are unchanged.Resulting behavior:
Local evidence — Node 24.19.0 / npm 11.9.0, same Studio-only setup as the exact base:
skipLibCheck: falseand negative numeric-geometry cases.tsc -bstill fails with 1,095 diagnostics, down from 1,206 at the exact fix(studio): restore editor control bindings for React 19 #78 base in the same setup. All 111 renderer diagnostics disappear; no new diagnostic fingerprints appear after normalizing line numbers. Hosted counts must be read separately.Sonar follow-up: the first head
91e9854f5833eb0654e8d2009ce0d632cc930afcfailed its SonarCloud gate, Reliability C on New Code (A required). Its ten GitHub annotations identify seven unnecessary void discard expressions in the compile-only fixture, two unhandled render promise chains and a complexity finding. The follow-up exports the same positive/negative type fixtures without discard expressions, handles asynchronous draw failures with two additional regression tests, and isolates unchanged crop arithmetic in a small typed helper. No scanner suppression/exclusion, threshold change or disabled rule is added.Hosted evidence — 2026-10-04, exact current head
e51f631d4215c8f2e1c925d3e57a38fb4999596a:91e9854failed gate, not proof that all repository security alerts or runtime gaps are resolved.Review/blockers: review crop parity, lock/visibility semantics, opacity composition, incomplete-shape handling and stale-load/resize cleanup. Unit tests keep actual hooks, prop updates and pointer handlers, but control native canvas/image boundaries; their drawing-command checks are not browser pixel or photo-decoding proof. Effect rendering remains incomplete (grid label / individual panel no-op), and pivot/clipping semantics, full strict compilation, primary Electron, persisted media/project round trips and live generation remain unfinished. The #70/#63/#73 dependency combination has not been retested with this batch. Keep #74 open and this PR in draft; no merge or commercial availability is claimed.
Scope and commands.