Skip to content

Support private Kustomize remote bases #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erasure-tanner wants to merge 1 commit into from
Closed

Support private Kustomize remote bases #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pkg/argo_client/manifests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,16 @@ func (a *ArgoClient) generateManifests(ctx context.Context, app v1alpha1.Applica

app.Spec.Sources = append([]v1alpha1.ApplicationSource{source}, refs...)

// Get repository with enriched credentials from ArgoCD database
enrichedRepo, err := argoDB.GetRepository(ctx, source.RepoURL, app.Spec.Project)
if err != nil {
return nil, fmt.Errorf("failed to get repository with credentials: %w", err)
}
log.Debug().Msgf("using repository with credentials for %s", source.RepoURL)

// Use enriched repo instead of basic repo URL
q := repoapiclient.ManifestRequest{
Repo: &v1alpha1.Repository{Repo: source.RepoURL},
Repo: enrichedRepo,
Revision: source.TargetRevision,
AppLabelKey: argoSettings.AppLabelKey,
AppName: app.Name,
Expand Down
Loading