Support private Kustomize remote bases#488
Closed
erasure-tanner wants to merge 1 commit into
Closed
Conversation
Fix manifest generation for ArgoCD applications that use Kustomize bases from private repositories by retrieving repository configuration with enriched credentials from ArgoCD's database. - Retrieve repository with credentials using argoDB.GetRepository() - Use enriched repository instead of basic RepoURL - Enables ArgoCD to authenticate when fetching private remote bases Fixes zapier#475
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for private Kustomize remote bases in kubechecks by ensuring that repository credentials are properly retrieved and passed to ArgoCD's manifest generation process. Previously, only the repository URL was provided, which worked for public repositories but failed for private ones.
Changes:
- Retrieve enriched repository credentials from ArgoCD database before generating manifests
- Pass the enriched repository object (containing credentials) instead of a basic repository URL to the manifest request
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #475