fixing the struct in the unit test for checking non breaking upgrade

yugabyte · Jan 4, 2025 · aebd856 · aebd856
1 parent 77d8106
commit aebd856
Showing 1 changed file with 40 additions and 38 deletions.
diff --git a/yb-voyager/cmd/common_test.go b/yb-voyager/cmd/common_test.go
@@ -134,15 +134,16 @@ func TestAssessmentReportStructs(t *testing.T) {
 				MigrationComplexity        string                                `json:"MigrationComplexity"`
 				SchemaSummary              utils.SchemaSummary                   `json:"SchemaSummary"`
 				Sizing                     *migassessment.SizingAssessmentReport `json:"Sizing"`
+				Issues                     []AssessmentIssue                     `json:"-"`
+				TableIndexStats            *[]migassessment.TableIndexStats      `json:"TableIndexStats"`
+				Notes                      []string                              `json:"Notes"`
 				UnsupportedDataTypes       []utils.TableColumnsDataTypes         `json:"UnsupportedDataTypes"`
 				UnsupportedDataTypesDesc   string                                `json:"UnsupportedDataTypesDesc"`
 				UnsupportedFeatures        []UnsupportedFeature                  `json:"UnsupportedFeatures"`
 				UnsupportedFeaturesDesc    string                                `json:"UnsupportedFeaturesDesc"`
 				UnsupportedQueryConstructs []utils.UnsupportedQueryConstruct     `json:"UnsupportedQueryConstructs"`
 				UnsupportedPlPgSqlObjects  []UnsupportedFeature                  `json:"UnsupportedPlPgSqlObjects"`
 				MigrationCaveats           []UnsupportedFeature                  `json:"MigrationCaveats"`
-				TableIndexStats            *[]migassessment.TableIndexStats      `json:"TableIndexStats"`
-				Notes                      []string                              `json:"Notes"`
 			}{},
 		},
 	}
@@ -196,6 +197,24 @@ func TestAssessmentReportJson(t *testing.T) {
 			},
 			FailureReasoning: "Test failure reasoning",
 		},
+		Issues: nil,
+		TableIndexStats: &[]migassessment.TableIndexStats{
+			{
+				SchemaName:      "public",
+				ObjectName:      "test_table",
+				RowCount:        Int64Ptr(100),
+				ColumnCount:     Int64Ptr(10),
+				Reads:           Int64Ptr(100),
+				Writes:          Int64Ptr(100),
+				ReadsPerSecond:  Int64Ptr(10),
+				WritesPerSecond: Int64Ptr(10),
+				IsIndex:         true,
+				ObjectType:      "Table",
+				ParentTableName: StringPtr("parent_table"),
+				SizeInBytes:     Int64Ptr(1024),
+			},
+		},
+		Notes: []string{"Test note"},
 		UnsupportedDataTypes: []utils.TableColumnsDataTypes{
 			{
 				SchemaName: "public",
@@ -262,23 +281,6 @@ func TestAssessmentReportJson(t *testing.T) {
 				MinimumVersionsFixedIn: map[string]*ybversion.YBVersion{"2024.1.1": newYbVersion},
 			},
 		},
-		TableIndexStats: &[]migassessment.TableIndexStats{
-			{
-				SchemaName:      "public",
-				ObjectName:      "test_table",
-				RowCount:        Int64Ptr(100),
-				ColumnCount:     Int64Ptr(10),
-				Reads:           Int64Ptr(100),
-				Writes:          Int64Ptr(100),
-				ReadsPerSecond:  Int64Ptr(10),
-				WritesPerSecond: Int64Ptr(10),
-				IsIndex:         true,
-				ObjectType:      "Table",
-				ParentTableName: StringPtr("parent_table"),
-				SizeInBytes:     Int64Ptr(1024),
-			},
-		},
-		Notes: []string{"Test note"},
 	}
 
 	// Make the report directory
@@ -341,6 +343,25 @@ func TestAssessmentReportJson(t *testing.T) {
 		},
 		"FailureReasoning": "Test failure reasoning"
 	},
+	"TableIndexStats": [
+		{
+			"SchemaName": "public",
+			"ObjectName": "test_table",
+			"RowCount": 100,
+			"ColumnCount": 10,
+			"Reads": 100,
+			"Writes": 100,
+			"ReadsPerSecond": 10,
+			"WritesPerSecond": 10,
+			"IsIndex": true,
+			"ObjectType": "Table",
+			"ParentTableName": "parent_table",
+			"SizeInBytes": 1024
+		}
+	],
+	"Notes": [
+		"Test note"
+	],
 	"UnsupportedDataTypes": [
 		{
 			"SchemaName": "public",
@@ -411,25 +432,6 @@ func TestAssessmentReportJson(t *testing.T) {
 				"2024.1.1": "2024.1.1.1"
 			}
 		}
-	],
-	"TableIndexStats": [
-		{
-			"SchemaName": "public",
-			"ObjectName": "test_table",
-			"RowCount": 100,
-			"ColumnCount": 10,
-			"Reads": 100,
-			"Writes": 100,
-			"ReadsPerSecond": 10,
-			"WritesPerSecond": 10,
-			"IsIndex": true,
-			"ObjectType": "Table",
-			"ParentTableName": "parent_table",
-			"SizeInBytes": 1024
-		}
-	],
-	"Notes": [
-		"Test note"
 	]
 }`