Introduced AssessmentIssue struct for flattening the issues reported …

…in AssessmentReport struct
yugabyte · Jan 2, 2025 · 77d8106 · 77d8106
1 parent f6f5737
commit 77d8106
Showing 1 changed file with 30 additions and 14 deletions.
diff --git a/yb-voyager/cmd/common.go b/yb-voyager/cmd/common.go
@@ -1176,20 +1176,36 @@ func getMigrationComplexityForOracle(schemaDirectory string) (string, error) {
 
 // TODO: consider merging all unsupported field with single AssessmentReport struct member as AssessmentIssue
 type AssessmentReport struct {
-	VoyagerVersion             string                                `json:"VoyagerVersion"`
-	TargetDBVersion            *ybversion.YBVersion                  `json:"TargetDBVersion"`
-	MigrationComplexity        string                                `json:"MigrationComplexity"`
-	SchemaSummary              utils.SchemaSummary                   `json:"SchemaSummary"`
-	Sizing                     *migassessment.SizingAssessmentReport `json:"Sizing"`
-	UnsupportedDataTypes       []utils.TableColumnsDataTypes         `json:"UnsupportedDataTypes"`
-	UnsupportedDataTypesDesc   string                                `json:"UnsupportedDataTypesDesc"`
-	UnsupportedFeatures        []UnsupportedFeature                  `json:"UnsupportedFeatures"`
-	UnsupportedFeaturesDesc    string                                `json:"UnsupportedFeaturesDesc"`
-	UnsupportedQueryConstructs []utils.UnsupportedQueryConstruct     `json:"UnsupportedQueryConstructs"`
-	UnsupportedPlPgSqlObjects  []UnsupportedFeature                  `json:"UnsupportedPlPgSqlObjects"`
-	MigrationCaveats           []UnsupportedFeature                  `json:"MigrationCaveats"`
-	TableIndexStats            *[]migassessment.TableIndexStats      `json:"TableIndexStats"`
-	Notes                      []string                              `json:"Notes"`
+	VoyagerVersion      string                                `json:"VoyagerVersion"`
+	TargetDBVersion     *ybversion.YBVersion                  `json:"TargetDBVersion"`
+	MigrationComplexity string                                `json:"MigrationComplexity"`
+	SchemaSummary       utils.SchemaSummary                   `json:"SchemaSummary"`
+	Sizing              *migassessment.SizingAssessmentReport `json:"Sizing"`
+	Issues              []AssessmentIssue                     `json:"-"` // disabled in reports till corresponding UI changes are done(json and html reports)
+	TableIndexStats     *[]migassessment.TableIndexStats      `json:"TableIndexStats"`
+	Notes               []string                              `json:"Notes"`
+
+	// fields going to be deprecated
+	UnsupportedDataTypes       []utils.TableColumnsDataTypes     `json:"UnsupportedDataTypes"`
+	UnsupportedDataTypesDesc   string                            `json:"UnsupportedDataTypesDesc"`
+	UnsupportedFeatures        []UnsupportedFeature              `json:"UnsupportedFeatures"`
+	UnsupportedFeaturesDesc    string                            `json:"UnsupportedFeaturesDesc"`
+	UnsupportedQueryConstructs []utils.UnsupportedQueryConstruct `json:"UnsupportedQueryConstructs"`
+	UnsupportedPlPgSqlObjects  []UnsupportedFeature              `json:"UnsupportedPlPgSqlObjects"`
+	MigrationCaveats           []UnsupportedFeature              `json:"MigrationCaveats"`
+}
+
+type AssessmentIssue struct {
+	Category              string
+	CategoryDescription   string
+	TypeName              string
+	TypeDescription       string
+	Impact                string
+	ObjectType            string
+	ObjectName            string
+	SqlStatement          string
+	DocsLink              string
+	MinimumVersionFixedIn map[string]*ybversion.YBVersion
 }
 
 type UnsupportedFeature struct {