test/e2e: define node resources #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
6 times, most recently
from
a31035b to
1e2b62a
Compare
koct9i
changed the title
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
5 times, most recently
from
c9d5882 to
3cfb613
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines e2e tests and CRD documentation while introducing node resource definitions for test environments. It standardizes context usage in tests (specCtx for cross-node operations), adds resource limits for operations and nodes, and improves logging/diagnostics to aid test stability and debugging.
- Add explicit CPU and memory limits for e2e operations and node specs used in tests
- Switch cross-node e2e calls to specCtx and enhance logging (nodes/pods state, stuck pods)
- Update CRD descriptions for DNS options; bump Kubernetes-related dependencies to align with new helpers
Reviewed changes
Copilot reviewed 58 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ytop-chart/templates/crds/cluster.ytsaurus.tech_ytsaurus.yaml | Clarifies CRD field descriptions for DNS resolver options (name/value). No functional change. |
| ytop-chart/templates/crds/cluster.ytsaurus.tech_remoteytsaurus.yaml | Same CRD description clarifications for remote cluster. |
| ytop-chart/templates/crds/cluster.ytsaurus.tech_remotetabletnodes.yaml | Same CRD description clarifications for remote tablet nodes. |
| ytop-chart/templates/crds/cluster.ytsaurus.tech_remoteexecnodes.yaml | Same CRD description clarifications for remote exec nodes. |
| ytop-chart/templates/crds/cluster.ytsaurus.tech_remotedatanodes.yaml | Same CRD description clarifications for remote data nodes. |
| ytop-chart/templates/crds/cluster.ytsaurus.tech_offshoredatagateways.yaml | Same CRD description clarifications for offshore data gateways. |
| test/e2e/ytsaurus_controller_test.go | Adds operation CPULimit/MemoryLimit; shifts cross-node client calls and object updates to specCtx; improves diagnostics (nodes state, pending/failed pods). |
| test/e2e/suite_test.go | Introduces specCtx lifecycle per test; logs nodes state in suite setup; removes global ctx usage to prevent leaks. |
| test/e2e/helpers_test.go | Adds logNodesState and fetchStuckPods; switches to specCtx for k8s calls; imports k8s.io/component-helpers/resource to compute pod requests. |
| pkg/testutil/spec_builders.go | Defines default resource requirements for various node types used in tests; applies these to builder-generated specs; adjusts exec node job environment (removes UserSlots). |
| go.mod | Bumps k8s api/apimachinery/client-go to v0.32.10 and adds component-helpers; updates ancillary deps to recent versions used by k8s tooling. |
| go.sum | Synchronizes checksums with updated dependencies. |
| config/crd/bases/* | Mirrors CRD description clarifications across controller CRD base files. No functional change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
3cfb613 to
d25b0d9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 58 out of 59 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
3 times, most recently
from
30c1185 to
822aa65
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
822aa65 to
2f25ea4
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
5b71ea2 to
ab02671
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
3 times, most recently
from
e8a2019 to
02997c3
Compare
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
02997c3 to
f2f1e26
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 60 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
f2f1e26 to
e2d52ed
Compare
Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
5c296dd to
762660d
Compare
Signed-off-by: Konstantin Khlebnikov <[email protected]>
Set limits for all nodes to get repeatable test results. Exec node needs to know own capacity. Defaults are bad. Explicit zero requests are important for fitting into test k8s. Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/test-e2e-set-node-resources
branch
from
762660d to
4b9cd82
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 58 out of 59 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.