Set data and tablet node resources in config #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koct9i
commented
Dec 8, 2025
koct9i
commented
- API: describe component and job resoruces control
- Set data and tablet node available CPU in config
Collaborator
Author
|
Merge after rebase on top #599 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves resource configuration for YTsaurus components by updating API documentation and implementing proper CPU resource limits for data and tablet nodes.
- Standardized resource field descriptions across CRDs to clarify that "Resources dedicated for component" with capacity defined by requests, or limits for zero requests
- Refactored data and tablet node configuration to extract and set CPU resource limits from Kubernetes resource specifications
- Updated test canonical data to reflect the new CPU values (changed from 0.000000 to 20.000000)
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
api/v1/ytsaurus_types.go |
Added documentation comments clarifying how resource capacity is determined for components and job resources |
docs/api.md |
Updated resource field descriptions to be more concise and added capacity definition details |
pkg/ytconfig/node.go |
Refactored getDataNodeResourceLimits and getTabletNodeServerCarcass to properly extract and set CPU resources using the getResourceQuantity helper function |
config/crd/bases/*.yaml |
Updated resource field descriptions to match the new standardized text |
ytop-chart/templates/crds/*.yaml |
Updated resource field descriptions to match the new standardized text |
pkg/ytconfig/canondata/**/test.canondata |
Updated test expectations to reflect CPU values changing from 0.000000 to 20.000000 for data and tablet nodes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koct9i
force-pushed
the
khlebnikov/set-data-and-tablet-node-resources
branch
3 times, most recently
from
7b3eccd to
98f3f94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/set-data-and-tablet-node-resources
branch
from
98f3f94 to
aabe1a2
Compare
Signed-off-by: Konstantin Khlebnikov <[email protected]>
koct9i
force-pushed
the
khlebnikov/set-data-and-tablet-node-resources
branch
from
aabe1a2 to
fc950d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.