Skip to content

Escape filepath.Match syntax#5

Open
gabyx wants to merge 2 commits into
yargevad:masterfrom
gabyx:bug/escape-characters
Open

Escape filepath.Match syntax#5
gabyx wants to merge 2 commits into
yargevad:masterfrom
gabyx:bug/escape-characters

Conversation

@gabyx
Copy link
Copy Markdown

@gabyx gabyx commented May 1, 2021

No description provided.

@gabyx gabyx force-pushed the bug/escape-characters branch 2 times, most recently from 0112b65 to 7572b8f Compare May 1, 2021 20:50
@gabyx gabyx changed the title Failing test Correctly escaping "[" chars May 1, 2021
@gabyx gabyx changed the title Correctly escaping "[" chars Correctly escaping pattern syntax in paths May 1, 2021
@gabyx gabyx force-pushed the bug/escape-characters branch from 7572b8f to 9f94135 Compare May 1, 2021 20:52
@gabyx gabyx changed the title Correctly escaping pattern syntax in paths Escape filepath.Match syntax May 1, 2021
@gabyx
Copy link
Copy Markdown
Author

gabyx commented May 1, 2021

Here the PR, with failing test.

- A path `/usr/bin/[` results in a pattern error.
  This fix resolves this.
@gabyx gabyx force-pushed the bug/escape-characters branch from 9f94135 to 4a00f82 Compare May 1, 2021 20:55
@gabyx
Copy link
Copy Markdown
Author

gabyx commented May 1, 2021

Thanks for merging. Maybe we could make the replacement faster. not sure...

@klauspost
Copy link
Copy Markdown

Since this project appears dead, I took the liberty to merge your changes into a fork

I had to make some additional fixes for the replacements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants