Replace the abandoned filepathx library with doublestar; ensure glob characters in paths do not break globbing#81
Merged
kylekthompson merged 2 commits intoOct 28, 2024
Conversation
…characters in paths do not break globbing
TAGraves
approved these changes
Oct 28, 2024
kylekthompson
deleted the
kt/test-filename-including-special-glob-chars
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was reported where Captain was returning an error (
Failed to assemble run command: unable to expand filepath glob: syntax error in pattern) given a very simple glob pattern against thetestdirectory:test/**/*_test.rb.It turns out that the test directory contained a file which had characters in the name that were special to
filepath.Glob. The library we were using to support doublestar globs was abandoned and did not properly handle escaping these (there's a PR up for it here: yargevad/filepathx#5).This PR moves us to https://github.com/bmatcuk/doublestar, a much more popular and maintained library for this.