-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asynchronous server with finer-grained I/O control #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to pass preserve_keys = true to array_slice()
…recision" in ::usleep()
This will ensure kept-alive HTTP sockets are closed after a while
Note: The statements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a nutshell
This pull request enhances the asynchronous server with finer-grained control for protocol handlers and scheduled tasks:
sleep()
, but again without blocking.Example
The request handlers in the xp-forge/web library can make use of the
yield
statement to hand back control to the server, which can then decide to handle other clients.However, the implementation simply resumes the handler at the first possible time, and the following
write()
could still potentially block for longer than necessary. To make the handler wait for the socket to become writeable, it needs to be changed as follows:Further uses
yield 'read' => $req;
to wait until the socket becomes readable.yield 'delay' => 300;
to wait for 300 milliseconds.The plain
yield
form is equivalent toyield 'delay' => 0;
.Intention
This functionality is intended to be used by library functions such as
web.Response::transmit()
or the file upload handling insidexp-forge/web
:For a discussion about a possible future scope, see xp-forge/rest-client#25 (comment)
See also