SLT-1232: Add storage.silta/storage-path annotation to Solr's volumeClaimTemplates #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Changes in silta.yaml are only for testing purposes, ignore those when merging.
Motivation:
Solr allows to override the
storageClassName
in helm chart values but is missing thestorage.silta/storage-path
annotation. If storage class is overridden tosilta-shared
ornfs-shared
, this will map Solr's data volume at{server}/{namespace-x}
rather{server}/{namespace-x}/{release-x}/solr-data
(i.e., similar to what shell’s volume would do: https://github.com/wunderio/charts/blob/e6613fcc83a28b1d5366efecf0446e44875cdbf3/drupal/templates/shell-volume.yaml#L41Mapping Solr's data volume to project's namespace folder can cause major issues on a project level, i.e.:
{namespace-x}
folder from the server associated with the overridden storage class due topersistentVolumeReclaimPolicy: Delete
set on the PV, causing major data loss.Changes proposed:
storage.silta/storage-path
annotation to Solr'svolumeClaimTemplates
if storage class is eithersilta-shared
ornfs-shared
accessModes
property from volumeClaimTemplate as unit tests were complaining about it.How to test:
/{namespace-x}/{release-x}/solr-data
Source.Path
(run below, make sure that you're using the correct kubectl context and namespace)k get pv | grep -i feature-slt-1232-storage-path-solr
k describe pv {pv-name-from-the-above-command-results}