Add storage.silta/storage-path annotation to Solr's volumeClaimTemplates #503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Solr allows to override the storageClassName in helm chart values but is missing the
storage.silta/storage-path
annotation. If storage class is overridden to silta-shared or nfs-shared, this will map Solr's data volume at{server_address}/{namespace-x}
rather{server_address}/{namespace-x}/{release-x}/solr-data
(i.e., similar to what shell’s volume would do:charts/drupal/templates/shell-volume.yaml
Line 41 in e6613fc
Mapping Solr's data volume to project's namespace folder can cause major issues on a project level, i.e.:
{server_address}/{namespace-x}
folder from the server associated with the overridden storage class due to persistentVolumeReclaimPolicy: Delete set on the PV, causing major data loss.Changes proposed:
storage.silta/storage-path
annotation to Solr's volumeClaimTemplates if storage class is eithersilta-shared
ornfs-shared
, we can't add it by default as patching existing PVC's will fail.accessModes
property fromvolumeClaimTemplate
as unit tests were complaining about it.How to test: