Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana: require that transfer is not released in redeem #275

Merged
merged 1 commit into from
Mar 7, 2024
Merged

solana: require that transfer is not released in redeem #275

merged 1 commit into from
Mar 7, 2024

Conversation

kcsongor
Copy link
Contributor

@kcsongor kcsongor commented Mar 7, 2024

No description provided.

@kcsongor kcsongor force-pushed the solana-require-not-redeemed branch 2 times, most recently from 74e8c5e to 10acaf5 Compare March 7, 2024 13:08
@kcsongor kcsongor requested review from johnsaigle and a5-pickle March 7, 2024 13:31
johnsaigle
johnsaigle approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good. I suggested a change that might be a bit more efficient but it can be done in a subsequent PR

a5-pickle
a5-pickle approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@a5-pickle a5-pickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just responded to your conversation w/ @johnsaigle about the release status check location. Like he says, can be changed in a subsequent PR.

@kcsongor kcsongor force-pushed the solana-require-not-redeemed branch from 10acaf5 to 5279268 Compare March 7, 2024 14:21
@johnsaigle
Copy link
Collaborator

When #219 is merged, it would be great to add a test for this change using the tools in that PR

@kcsongor kcsongor merged commit ba243c6 into main Mar 7, 2024
4 checks passed
@kcsongor kcsongor deleted the solana-require-not-redeemed branch March 7, 2024 14:40
@kcsongor
Copy link
Contributor Author

kcsongor commented Mar 7, 2024

When #219 is merged, it would be great to add a test for this change using the tools in that PR

that was my thinking too!

@johnsaigle johnsaigle mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsaigle johnsaigle johnsaigle approved these changes

@a5-pickle a5-pickle a5-pickle approved these changes

@felix-asym felix-asym felix-asym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kcsongor @johnsaigle @a5-pickle @felix-asym