solana: require that transfer is not released in redeem

Author: kcsongor

solana/programs/example-native-token-transfers/src/error.rs

@@ -19,6 +19,8 @@ pub enum NTTError {
     InvalidRecipientNttManager,
     #[msg("TransferAlreadyRedeemed")]
     TransferAlreadyRedeemed,
+    #[msg("TransferCannotBeRedeemed")]
+    TransferCannotBeRedeemed,
     #[msg("TransferNotApproved")]
     TransferNotApproved,
     #[msg("MessageAlreadySent")]

solana/programs/example-native-token-transfers/src/instructions/redeem.rs

@@ -134,7 +134,7 @@ pub fn redeem(ctx: Context<Redeem>, _args: RedeemArgs) -> Result<()> {
         RateLimitResult::Delayed(release_timestamp) => release_timestamp,
     };
 
-    accs.inbox_item.release_status = ReleaseStatus::ReleaseAfter(release_timestamp);
+    accs.inbox_item.release_after(release_timestamp)?;
 
     Ok(())
 }

solana/programs/example-native-token-transfers/src/queue/inbox.rs

@@ -45,6 +45,14 @@ impl InboxItem {
             ReleaseStatus::Released => Err(NTTError::TransferAlreadyRedeemed.into()),
         }
     }
+
+    pub fn release_after(&mut self, release_timestamp: i64) -> Result<()> {
+        if self.release_status != ReleaseStatus::NotApproved {
+            return Err(NTTError::TransferCannotBeRedeemed.into());
+        };
+        self.release_status = ReleaseStatus::ReleaseAfter(release_timestamp);
+        Ok(())
+    }
 }
 
 /// Inbound rate limit per chain.