Skip to content

Remove the pickOne mode from TagsView #24676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feature/tags-data-view-site-settings
Choose a base branch
from
Draft

Remove the pickOne mode from TagsView #24676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions WordPress/Classes/ViewRelated/Tags/TagsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ private struct TagRowView: View {
switch viewModel.mode {
case .selection:
viewModel.toggleSelection(for: tag)
case .pickOne(let onTagTapped):
onTagTapped(tag)
case .browse:
break
}
Expand Down Expand Up @@ -343,9 +341,6 @@ class TagsViewController: UIHostingController<TagsView> {
self.init(blog: blog, selectedTags: selectedTags, mode: .selection(onSelectedTagsChanged: onSelectedTagsChanged))
}

convenience init(blog: Blog, onTagTapped: @escaping (RemotePostTag) -> Void) {
self.init(blog: blog, mode: .pickOne(onTagTapped: onTagTapped))
}

convenience init(blog: Blog) {
self.init(blog: blog, mode: .browse)
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/ViewRelated/Tags/TagsViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ typealias TagsPaginatedResponse = DataViewPaginatedResponse<RemotePostTag, Int>

enum TagsViewMode {
case selection(onSelectedTagsChanged: ((String) -> Void)?)
case pickOne(onTagTapped: (RemotePostTag) -> Void)
case browse
}

Expand Down