Skip to content

Remove the pickOne mode from TagsView #24676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: feature/tags-data-view-site-settings
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

Description

I originally planned to use the pickOne mode for adding tags as menu items. But after trying that, it did not work out. Because the menu item editing (MenuItemSourceResultsViewController specifically) is coupled with UITableView and UISearchBar - they need to be used by the tags selection view. We can't do that, because TagsView is implemented in SwiftUI.

@dangermattic
Copy link
Collaborator

dangermattic commented Jul 16, 2025

2 Warnings
⚠️ Translation files *.lproj/Localizable.strings should only be updated on a release branch.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 16, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number28220
VersionPR #24676
Bundle IDorg.wordpress.alpha
Commit2a5e93e
Installation URL7erpr0s9s3reo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 16, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number28220
VersionPR #24676
Bundle IDcom.jetpack.alpha
Commit2a5e93e
Installation URL7jv3csd7booao
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli force-pushed the feature/tags-data-view-remove-pick-one branch from 058289d to 2a5e93e Compare July 20, 2025 23:49
@crazytonyli crazytonyli force-pushed the feature/tags-data-view-site-settings branch from be9d74a to c6e06bd Compare July 20, 2025 23:51
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants