Add E2E tests for cross-component navigation flow#1119
Closed
BonnieZ-data wants to merge 2 commits into
Closed
Conversation
amyjko
requested changes
May 15, 2026
Collaborator
amyjko
left a comment
amyjko
left a comment
There was a problem hiding this comment.
Did you intend to include the SetLiteral.test.ts file in this PR? It seems unrelated to this PR's scope.
Also, there are some brittle domains in the e2e test to fix.
| test.describe('Editor → Output cross-component flow', () => { | ||
|
|
||
| test('home page loads successfully', async ({ page }) => { | ||
| await page.goto('http://localhost:5173/en-US'); |
Collaborator
There was a problem hiding this comment.
These should not be hard coded with https://localhost:5173. Just pass the path, not the domain. Not every platform will use this port.
| }); | ||
|
|
||
| test('navigating to Learn page works', async ({ page }) => { | ||
| await page.goto('http://localhost:5173/en-US'); |
| }); | ||
|
|
||
| test('navigating to Guide page works', async ({ page }) => { | ||
| await page.goto('http://localhost:5173/en-US'); |
| }); | ||
|
|
||
| test('language switcher is present on home page', async ({ page }) => { | ||
| await page.goto('http://localhost:5173/en-US'); |
Contributor
Author
|
Hi @amyjko , thanks for the feedback! I've removed the hardcoded localhost domains and moved the SetLiteral.test.ts to a separate branch. I'll close this PR and open a new one from the correct branch shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Adds a new end-to-end test suite covering cross-component navigation interactions — an area with no prior test coverage.
What this tests
Why this matters
Navigation between the home page and major sections (Learn, Guide) spans multiple Svelte components and had zero E2E test coverage. A regression here would affect all users on first visit.
Related issues