Update Kyber APIs to ML-KEM APIs #8536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change struct KyberKey to struct MlKemKey - Add backward compatibility typedef for KyberKey - Add function declarations for new wc_MlKemKey_ functions - Add backward compatibility #defines to map old wc_KyberKey APIs to new wc_MlKemKey APIs - Update wc_MlKemKey_Init to take key first and type second - Create new files wc_mlkem.h and wc_mlkem.c with updated content - Update internal APIs with lowercase kyberkey to lowercase mlkemkey Co-Authored-By: [email protected] <[email protected]>
SparkiDev
force-pushed
the
kyber_to_mlkem
branch
5 times, most recently
from
bf4a796 to
0b886ad
Compare
SparkiDev
force-pushed
the
kyber_to_mlkem
branch
from
0b886ad to
a7690ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Guided work by Devin:
- Change struct KyberKey to struct MlKemKey
- Add backward compatibility typedef for KyberKey
- Add function declarations for new wc_MlKemKey_ functions
- Add backward compatibility #defines to map old wc_KyberKey APIs to new wc_MlKemKey APIs
- Update wc_MlKemKey_Init to take key first and type second
- Create new files wc_mlkem.h and wc_mlkem.c with updated content
- Update internal APIs with lowercase kyberkey to lowercase mlkemkey
Other work by Sean Parkinson
Testing
Regression tested.
Checklist