Update Kyber APIs to ML-KEM APIs #8532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Change struct KyberKey to struct MlKemKey - Add backward compatibility typedef for KyberKey - Add function declarations for new wc_MlKemKey_ functions - Add backward compatibility #defines to map old wc_KyberKey APIs to new wc_MlKemKey APIs - Update wc_MlKemKey_Init to take key first and type second - Create new files wc_mlkem.h and wc_mlkem.c with updated content - Update internal APIs with lowercase kyberkey to lowercase mlkemkey Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@devin-ai-integration[bot] |
|
Can one of the admins verify this patch? |
|
Work finished in #8536 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Kyber APIs to ML-KEM APIs
This PR updates the Kyber APIs in the wolfSSL repository to use the wc_MlKemKey prefix and adds backward compatibility defines for existing wc_KyberKey APIs.
Changes
Testing
The changes have been tested with the configuration option
--disable-shared --enable-kyber.Link to Devin run
https://app.devin.ai/sessions/b84d53668bc44fb8a7bd1ea5815a42d9
Requested by
[email protected]