fix(ch6): wire epilogue bridge, Vancouver art, and tester overlay#44
Merged
Conversation
- Add epilogue_bridge choice before home_scene so Ch 6 Vancouver is actually reachable from normal play (was orphaned behind a direct jump from fly_home to home_scene). - Point Ch 6 screens at the real painterly art shipped in #38; they were still using Ch1-5 placeholder backgrounds so testers saw Kyoto/Tel Aviv images during the Vancouver scenes. - Chain vancouver_outro -> home_scene so the sacred final line plays once after the epilogue instead of dead-ending. - Add defensive tester_route inside volume_select so ?tester=1 still routes to chapter_select even if the main: frame races the VM tick. - Hide the .pnk-switcher volume deep-link chip in tester mode; the chapter-picker panel already covers that affordance and the chip collided visually with the TESTER MODE ribbon. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for p-n-k-forever ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes Chapter 6 (Vancouver) flow and presentation issues in the v1-modern Narrat build, ensuring the epilogue is reachable in normal play, renders with the correct Vancouver art, and returns cleanly to the final ending while also cleaning up tester-mode UI.
Changes:
- Added an
epilogue_bridgechoice afterfly_hometo route either into the Vancouver epilogue or directly tohome_scene. - Updated Chapter 6 (Vancouver) outro to jump to
home_scene, and updated config to use the shipped Vancouver background PNGs. - Hardened tester routing and hid the volume switcher chip overlay in tester mode to prevent UI collision.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| v1-modern/src/scripts/japan.narrat | Routes fly_home into a new epilogue_bridge choice (epilogue vs. come home). |
| v1-modern/src/scripts/vancouver.narrat | Ensures vancouver_outro chains to home_scene (no dead-end). |
| v1-modern/public/data/config.yaml | Points Chapter 6 screens at the Vancouver art assets (no placeholders). |
| v1-modern/src/scripts/game.narrat | Adds a defensive tester_route at volume_select to mitigate VM tick timing. |
| v1-modern/src/plugins/tester-plugin.ts | Hides .pnk-switcher overlay chip in tester mode to reduce UI noise/collision. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four production bugs reported during playtest of the v1-modern build. All fixed in a single commit:
Chapter 6 (Vancouver) unreachable from normal play.
fly_homejumped straight tohome_scene(the sacred Tel Aviv ending), so the epilogue was orphaned — only reachable via?tester=1chapter picker.Ch 6 scenes rendered with Ch 1–5 art.
config.yamlstill pointed the six Vancouver screens at placeholder backgrounds (beach_rest,kyoto_apt,sunset,beach,kitchen,home) from before #38 shipped the real painterly Vancouver art. So testers entered Ch 6 and saw Tel Aviv / Kyoto images.vancouver_outrodead-ended instead of chaining back to the sacred final line..pnk-switcher"Vol 1 Throwback" overlay chip visible in tester mode, colliding with theTESTER MODEribbon and offering a redundant off-ramp that testers don't need (chapter-picker already covers that affordance).Also added a defensive
tester_routecall inside thevolume_selectlabel to guard against a VM-tick race where themain:frame can advance past the firsttester_routebeforejumpToLabellands.Changes
v1-modern/src/scripts/japan.narratepilogue_bridgechoice: continue-to-epilogue / come-homev1-modern/src/scripts/vancouver.narratvancouver_outronowjump home_scenev1-modern/public/data/config.yamlv1-modern/src/scripts/game.narrattester_routeinsidevolume_selectv1-modern/src/plugins/tester-plugin.tshideSwitcherChip()in tester modeSacred line invariant preserved
home_scenestill ends with"For Anastasia. Forever."— the only change is thatvancouver_outronow hands off to it, so the sacred line plays exactly once whether the player takes the normal ending or the full epilogue path. See .claude/rules/narrat-no-autoplay-loops.md.Test plan
npm run buildgreen?tester=1→ chapter_select renders all 6 chapterswindow.narrat.jump(<label>)for all five labels:vancouver_intro→kits_beach.png,vancouver_apt_scene→vancouver_apt.png,did_squamish→squamish.png,did_persian→north_van_persian.png,did_costco→costco_downtown.png,did_trails→vancouver_peak.png.pnk-switchercomputeddisplay: nonein tester mode; visible in normal mode🤖 Generated with Claude Code