Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #245 - Addressing new popover values #247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix #245 - Addressing new popover values #247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57139fb
Fix #245 - Addressing new popover values
theIDinside Mar 17, 2025
16a6593
Wrap in <a>
theIDinside Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions fullscreen.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ Markup Shorthands: css no
</pre>

<pre class=link-defaults>
spec:html
type:dfn; text:allowed to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI Reviewers: This is to fix the build as it's currently broken (see #246 for a standalone PR to fix that if that's preferable)

type:dfn; text:showing hint popover list
type:dfn; text:showing auto popover list
Copy link
Member

@lukewarlow lukewarlow Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't currently exported so are manually added here. PR to export them: whatwg/html#11140

Copy link
Author

@theIDinside theIDinside Mar 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just remove these from this PR then, right?

Nvm :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once that gets merged yeah you should be able to remove these, useful to keep them for now so the preview works


spec:dom
type:dfn; for:/; text:document
type:dfn; for:/; text:element
Expand Down Expand Up @@ -69,11 +74,16 @@ is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is
<p>To <dfn>fullscreen an <var>element</var></dfn>:

<ol>
<li><p>Let <var>document</var> be <var>element</var>'s <a>node document</a>.

<li><p>Let <var>hideUntil</var> be the result of running <a>topmost popover ancestor</a> given
<var>element</var>, null, and false.
<var>element</var>, <var>document</var>'s <a>showing hint popover list</a>, null, and false.

<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to the result of running
<a>topmost popover ancestor</a>, given <var>element</var>, <var>document</var>'s <a>showing auto popover
list</a>, null, and false.

<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to <var>element</var>'s
<span>node document</span>.
<li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to <var>document</var>.

<li><p>Run <a>hide all popovers until</a> given <var>hideUntil</var>, false, and true.

Expand Down Expand Up @@ -725,6 +735,7 @@ Rafał Chłodnicki,
Riff Jiang,
Rune Lillesveen,
Sigbjørn Vik,
Simon Farre,
Simon Pieters,
Tab Atkins-Bittner,
Takayoshi Kochi,
Expand Down