Fix #245 - Addressing new popover values #247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the popover attribute got a new value, it's "find topmost popover ancestor" algorithm changed, and this PR attempts to address this in the Fullscreen API specification. After discussing with Luke Warlow we came to the conclusion that this is probably the intended change for the Fullscreen API spec.
lukewarlow
reviewed
Mar 17, 2025
lukewarlow
reviewed
Mar 17, 2025
| @@ -11,6 +11,11 @@ Markup Shorthands: css no | |||
| </pre> | |||
|
|
|||
| <pre class=link-defaults> | |||
| spec:html | |||
| type:dfn; text:allowed to use | |||
There was a problem hiding this comment.
FYI Reviewers: This is to fix the build as it's currently broken (see #246 for a standalone PR to fix that if that's preferable)
lukewarlow
reviewed
Mar 17, 2025
| spec:html | ||
| type:dfn; text:allowed to use | ||
| type:dfn; text:showing hint popover list | ||
| type:dfn; text:showing auto popover list |
There was a problem hiding this comment.
These aren't currently exported so are manually added here. PR to export them: whatwg/html#11140
There was a problem hiding this comment.
Probably just remove these from this PR then, right?
Nvm :P
There was a problem hiding this comment.
Once that gets merged yeah you should be able to remove these, useful to keep them for now so the preview works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the popover attribute got a new value, it's
"find topmost popover ancestor" algorithm changed, and this PR attempts to address this in the Fullscreen API specification.
After discussing with @lukewarlow we came to the conclusion that this is probably the intended change for the Fullscreen API spec.
This addresses #245
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff