Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update non-normative text for DirectoryHandle's removeEntry() #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update non-normative text for DirectoryHandle's removeEntry() #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4f5924
Update non-normative section for removeEntry()
rahulsingh-msft Dec 18, 2024
c406d21
Avoid using 'will' in updated text
rahulsingh-msft Dec 18, 2024
068f1e2
One more update
rahulsingh-msft Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,15 +979,18 @@ The <dfn method for=FileSystemDirectoryHandle>getDirectoryHandle(|name|, |option
[=FileSystemHandle/locator=] contains a file named |name|, or an empty
directory named |name|, this will attempt to delete that file or directory.

Attempting to delete a file or directory that does not exist is considered success,
while attempting to delete a non-empty directory will result in a promise rejection.
Attempting to delete a file or directory that does not exist results in a promise
being rejected with a "NotFoundError" DOMException. Attempting to delete a non-empty
directory results in a promise being rejected with an "InvalidModificationError"
DOMException.

: await |directoryHandle| . {{FileSystemDirectoryHandle/removeEntry()|removeEntry}}(|name|, { {{FileSystemRemoveOptions/recursive}}: true })
:: Removes the [=/file system entry=] named |name| in the [=directory entry=]
[=locate an entry|locatable=] by |directoryHandle|'s [=FileSystemHandle/locator=].
If that entry is a directory, its contents will also be deleted recursively.

Attempting to delete a file or directory that does not exist is considered success.
Attempting to delete a file or directory that does not exist results in a promise
being rejected with a "NotFoundError" DOMException.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to presuppose an outcome to #11. The normative text doesn't seem to currently reject at all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a first look @annevk! I'll pick this back up after the holidays. Will work with @diekus to get the Participant Data updated in the meantime.

</div>

<div algorithm>
Expand Down Expand Up @@ -1758,6 +1761,7 @@ Marcos Cáceres,
Martin Thomson,
Olivier Yiptong,
Philip Jägenstedt,
Rahul Singh,
Randell Jesup,
Richard Stotz,
Ruth John,
Expand Down
Loading