Update non-normative text for DirectoryHandle's removeEntry() #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rahulsingh-msft you need to work with someone at Microsoft (possibly @diekus) to get https://github.com/whatwg/participant-data updated as Microsoft currently hasn't signed up for the Storage Workstream (see also https://whatwg.org/workstreams). |
annevk
reviewed
Dec 19, 2024
|
|
||
| : await |directoryHandle| . {{FileSystemDirectoryHandle/removeEntry()|removeEntry}}(|name|, { {{FileSystemRemoveOptions/recursive}}: true }) | ||
| :: Removes the [=/file system entry=] named |name| in the [=directory entry=] | ||
| [=locate an entry|locatable=] by |directoryHandle|'s [=FileSystemHandle/locator=]. | ||
| If that entry is a directory, its contents will also be deleted recursively. | ||
|
|
||
| Attempting to delete a file or directory that does not exist is considered success. | ||
| Attempting to delete a file or directory that does not exist results in a promise | ||
| being rejected with a "NotFoundError" DOMException. |
There was a problem hiding this comment.
This change seems to presuppose an outcome to #11. The normative text doesn't seem to currently reject at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates only the non-normative section for
FileSystemDirectoryHandle's removeEntry() method.
It clarifies that the Promise is rejected with a "NotFoundError"
DOMException when an entry corresponding to the
nameparameter doesnot exist.
Further, it adds that the Promise is rejected with an
"InvalidModificationError" DOMException when attempting to remove a
non-empty directory with the
recursiveoption set to false.These updates were made to align the non-normative text with the
algorithm for removeEntry() outlined in the File System Standard.
See here: https://fs.spec.whatwg.org/#api-filesystemdirectoryhandle-removeentry
Preview | Diff