Allow options via query.

[izaakschroeder]

When webpack@2 lands there will no longer be any this.options. Since query can now be a vanilla object instead of a string, having options reside in query is a quick, non-destructive fix.

See:

• Pass proper loader options to children. extract-text-webpack-plugin#266
• Initial support for webpack@2. webpack-config/webpack-config-postcss#10

[ai]

Why extra option instead of having option in root level in query?

[izaakschroeder]

The query itself must either be object or string and it's nice to have options as a function. It's also the least intrusive change.

[ai]

Maybe we should name it as plugins?

[izaakschroeder]

Yea we could do query.plugins instead of query.options; that works. 👍

[izaakschroeder]

Thanks! Let me know when a new version is published @ai 😄

[ai]

I just need to update docs, add result.messages with dependencies and we are ready for release.

[izaakschroeder]

👌

[ai]

I finished all changes and ready for release. Could you test this plugin on real application? (Just replace version in package.json to postcss/postcss-loader)

[michael-ciniawsky]

webpack v2.1.0-beta.25

LoaderOptionsPlugin: ✅
postcss.config.js: 🚫

I'm on it... :)

[izaakschroeder]

Will try and get this working will my configuration tonight 😄

[izaakschroeder]

@ai Running into a few hiccups. First of which is ./node_modules/postcss-load-config/index.js. There's some mismatch between versions going on here, where that file is trying to require postcss-load-options/lib/loadOptions.js which doesn't exist; the file is instead called postcss-load-options/lib/options.js. I'm not sure which version is intended to be correct or where the mismatch is coming from.

[izaakschroeder]

@ai The way you've refactored parseOptions also results in failing to pass the webpack context through.

return parseOptions(options, pack);

should be:

return parseOptions(loader, options, pack);

and then:

function parseOptions(context, options, pack) {
// ...
options = options.call(context, context);

This will break postcss-imports (and possibly more) otherwise.

[izaakschroeder]

You can verify these by checking out the branch here: webpack-config/webpack-config-postcss#10 and running npm run smoke.

[michael-ciniawsky]

@izaakschroeder postcss-load-config issue should be fixed now.

[izaakschroeder]

Thanks @michael-ciniawsky it is 😄 Just waiting on @ai now.