This repository was archived by the owner on May 29, 2019. It is now read-only.
Pass proper loader options to children.
#266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using just the serialized request means that query objects (that is to say, those which are not strings), get munged if they have anything non-serializable in them. This means passing data to `postcss` via `query` is impossible. To remedy this, we detect when the original request is being processed and apply the original loader transformations instead of whatever came through the serialized version.
This was referenced Oct 7, 2016
Current coverage is 86.05% (diff: 100%)@@ master #266 diff @@
==========================================
Files 4 4
Lines 332 337 +5
Methods 68 69 +1
Messages 0 0
Branches 71 72 +1
==========================================
+ Hits 285 290 +5
Misses 47 47
Partials 0 0
|
|
/ping @sokra |
|
/ping @sokra |
|
Looks like a good idea to me. I wouldn't worry about Node 0.12. |
|
/ping @sokra |
|
@bebraw @d3viant0ne Ahh... damn 😛 I missed that one, it is actually quite important for postcss-loader, just saw it popping up in timeline. @izaakschroeder Could you reword the commits to e.g
🙏 so we can make a quick release ? |
|
@michael-ciniawsky - I'll see to it in a minute. |
|
Included in |
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 8, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 8, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 9, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 10, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 23, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 24, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 24, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 24, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
brianhelba
added a commit
to girder/girder
that referenced
this pull request
May 24, 2017
…nfig The 'extract-text-webpack-plugin' was already being used at version '2.1.0' (hence the changes in #1981 ), so this commit updates the package dependency to ensure that older versions are not used with the new option syntax. This new version should now properly pass on options to child loaders ( webpack-contrib/extract-text-webpack-plugin#266 ), so the options to 'stylus-loader' can now use a clearer syntax. This also adds a comment to explain a poorly documented 'stylus-loader' option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using just the serialized request means that query objects (that is to say, those which are not strings), get munged if they have anything non-serializable in them. This means passing data to
postcssviaqueryis impossible. To remedy this, we detect when the original request is being processed and apply the original loader transformations instead of whatever came through the serialized version.Build seems to be only failing on
[email protected]butwebpack@2doesn't support that.. so..See:
optionsviaquery. postcss-loader#104/cc @sokra