Skip to content

Conversation

reusteur73
Copy link
Contributor

@reusteur73 reusteur73 commented Oct 2, 2025

To get the build working, I had to make some code changes. Here’s how I structured the commits:

  • First commit: a raw copy of the 1.21.6–1.21.8 versions.
  • Second commit adc68ad contains the edits required to make the build succeed. Some of these changes may be incorrect or cause errors, so please review this commit carefully. ⚠️

The build works and the required legacy textures display correctly, but the new copper textures are not supported since DynmapCore was not updated.

@reusteur73
Copy link
Contributor Author

reusteur73 commented Oct 6, 2025

Summary

This update adds missing texture definitions so several blocks can now render properly on the map.

Changes

Added missing textures for the following blocks:

  • Copper bars, lightning rod, chain, lantern, and torch (including all exposed, oxidized, and waxed variants)
  • All wooden shelf variants
  • Cactus flower, wildflowers, firefly bush
  • Leaf litter, resin clump
  • Short and tall dry grass

Known Issues

  • Copper chests and copper golem statues are still not rendering.
    • Their textures are stored in the /entity folder, which DynmapBlockScan doesn’t currently handle.
    • Additionally, copper chests appear to use a different texture structure than classic or ender chests.
2025-10-06 195710

@jsvdmeer
Copy link

jsvdmeer commented Oct 6, 2025

Great work! Build it successfully this morning and tried it on my server. Seems to work great so far except for the copper chests that you already mentioned. But its good enough to play on 1.21.9 for now :).
Thanks!

@reusteur73
Copy link
Contributor Author

reusteur73 commented Oct 6, 2025

As requested on Discord, here’s the compiled JAR for this update.
Supports Fabric 1.21.9 and 1.21.10-rc1 1.21.10.

@reusteur73
Copy link
Contributor Author

Summary

Adds support for 1.21.10, grouped under a single subproject that includes both 1.21.9 and 1.21.10.

@reusteur73
Copy link
Contributor Author

Copper Chests Support:

Copper chests are now supported!

image

I manually created a copper_{tier}_double.png texture for each copper tier. (45f5b72)

I also fixed simple chests (all types). It seems the top texture wasn’t the correct one, as shown here (I tested in 1.21.6 and saw the same issue).
To fix this, I edited all normal.png chest textures accordingly. (68fe8fd)

Notes:

It seems that normal_double.png is no longer used in newer Minecraft versions, possibly due to changes in how double chests are rendered.
I checked the latest few versions and found no trace of it.

To work around this, I manually recreated the copper double chest textures based on the old double chest model.


Fabric Permissions API: (e7e8588)

As mentioned on Discord, the dependency me.lucko:fabric-permissions-api:0.1-SNAPSHOT no longer works.

I downloaded the JAR from the official lucko/fabric-permissions-api repository and verified it with the following SHA-256 checksum:
eafed55e6d2ee49c7be89bdc7378433521f65c3ca3100d43aaf50cfecd48ec77

The JAR has been placed in /libs/external for now.
I also updated the Fabric subprojects that depend on it to reference this local path, ensuring builds for other Fabric modules work correctly.


The only new 'block' not yet supported is copper statue.

@jacob1
Copy link
Contributor

jacob1 commented Oct 8, 2025

Awesome. I actually tried to go down the path of creating new _double.png textures to give to you, but then gave up because the pixels weren't lining up nicely. Then I tried checking what it would take to fix the single chest textures on the java side of things, but I couldn't figure out how the java side is pulling portions of the texture data to display. Definitely something I'm missing in my understanding of the model code.

Your workaround work just fine though. Single chests have been broken and bothering me for a while.

@jacob1
Copy link
Contributor

jacob1 commented Oct 8, 2025

For the fabric api, 0.1-SNAPSHOT must be really old, the latest version is 0.5.0 and should be in maven central. Maybe just changing the version to that would solve the issue?

@reusteur73
Copy link
Contributor Author

Fabric Permissions API: (4fd96ec)

For the fabric api, 0.1-SNAPSHOT must be really old, the latest version is 0.5.0 and should be in maven central. Maybe just changing the version to that would solve the issue?

Yes, correct. I hadn’t tried initially. I tried 0.5.0, which works for 1.21.10, but causes build issues for other Fabric projects.
Using 0.4.0 for those versions seems to work fine.


Loom Version: (2b7e799)

When compiling all Fabric versions, I encountered build errors in most of them.
Updating to the latest Loom snapshot resolved the issue, and I was able to compile all Fabric versions successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants