-
Notifications
You must be signed in to change notification settings - Fork 455
Fabric 1.21.9 initial support #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3.0
Are you sure you want to change the base?
Conversation
Great work! Build it successfully this morning and tried it on my server. Seems to work great so far except for the copper chests that you already mentioned. But its good enough to play on 1.21.9 for now :). |
As requested on Discord, here’s the compiled JAR for this update. |
SummaryAdds support for 1.21.10, grouped under a single subproject that includes both 1.21.9 and 1.21.10. |
Copper Chests Support:Copper chests are now supported! ![]() I manually created a I also fixed simple chests (all types). It seems the top texture wasn’t the correct one, as shown here (I tested in 1.21.6 and saw the same issue). Notes:It seems that To work around this, I manually recreated the copper double chest textures based on the old double chest model. Fabric Permissions API: (e7e8588)As mentioned on Discord, the dependency I downloaded the JAR from the official lucko/fabric-permissions-api repository and verified it with the following SHA-256 checksum: The JAR has been placed in The only new 'block' not yet supported is copper statue. |
Awesome. I actually tried to go down the path of creating new _double.png textures to give to you, but then gave up because the pixels weren't lining up nicely. Then I tried checking what it would take to fix the single chest textures on the java side of things, but I couldn't figure out how the java side is pulling portions of the texture data to display. Definitely something I'm missing in my understanding of the model code. Your workaround work just fine though. Single chests have been broken and bothering me for a while. |
For the fabric api, 0.1-SNAPSHOT must be really old, the latest version is 0.5.0 and should be in maven central. Maybe just changing the version to that would solve the issue? |
Fabric Permissions API: (4fd96ec)
Yes, correct. I hadn’t tried initially. I tried 0.5.0, which works for 1.21.10, but causes build issues for other Fabric projects. Loom Version: (2b7e799)When compiling all Fabric versions, I encountered build errors in most of them. |
To get the build working, I had to make some code changes. Here’s how I structured the commits:
The build works and the required legacy textures display correctly,
but the new copper textures are not supported since DynmapCore was not updated.