Spigot/Paper 1.21.9-1.21.10 support

[jacob1]

All of the bukkit mappings are updated for 1.21.9/1/21.10. There were a lot of obfuscated method changes, as usual. No major api changes this time.

I did some initial testing and it loads / renders fine. Once the corresponding Fabric PR #4240 is merged, it will also render The Copper Age blocks.

I put a jar download on my fork for anyone that needs it before this PR is merged. (it's a combination of my and reusteur73's PRs so will render the new blocks).

[jacob1]

Update: Someone tested it on paper and it doesn't work. It gives this error:

java.lang.NoClassDefFoundError: net/minecraft/core/HolderLookup$a
	at java.base/java.lang.Class.forName0(Native Method) ~[?:?]
	at java.base/java.lang.Class.forName(Class.java:578) ~[?:?]
	at java.base/java.lang.Class.forName(Class.java:557) ~[?:?]
	at io.papermc.reflectionrewriter.runtime.AbstractDefaultRulesReflectionProxy.forName(AbstractDefaultRulesReflectionProxy.java:68) ~[reflection-rewriter-runtime-0.0.3.jar:?]
	at io.papermc.paper.pluginremap.reflect.PaperReflectionHolder.forName(Unknown Source) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar/org.dynmap.bukkit.Helper.loadVersionHelper(Helper.java:13) ~[Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar:?]
	at Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar/org.dynmap.bukkit.Helper.getHelper(Helper.java:59) ~[Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar:?]
	at Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar/org.dynmap.bukkit.DynmapPlugin.onLoad(DynmapPlugin.java:900) ~[Dynmap-3.7-beta-11-1.21.9-spigot-spigot.jar:?]
	at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:18) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:39) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:39) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at org.bukkit.craftbukkit.CraftServer.loadPlugins(CraftServer.java:554) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:323) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1096) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:317) ~[paper-1.21.9.jar:1.21.9-38-27f926e]
	at java.base/java.lang.Thread.run(Thread.java:1575) ~[?:?]
Caused by: java.lang.ClassNotFoundException: net.minecraft.core.HolderLookup$a
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:205) ~[paper-api-1.21.9-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:172) ~[paper-api-1.21.9-R0.1-SNAPSHOT.jar:?]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:528) ~[?:?]
	... 17 more

Not sure what it means yet. Paper 1.21.9 isn't officially released yet so if it's on their end, maybe it will be resolved.

[Tsoccerguy3]

Paper 1.21.9 build 41 is here https://papermc.io/downloads/paper . Paper is now a Hard Fork and new versions are developed along with the snapshots , that is why Paper gets releases on the same day as a Mojang release. 1.21.9 has been available for weeks for developers on the dev/1.21.9branch as was 1.21.8
Developers From Microsoft and Mojang contribute to the Code and to plugins Example Worldgard, worldedit Multicore Essentials etc..

Thanks Jacob for updating .

[jacob1]

I guess I was looking in the wrong places, then. I see now they have a button to show the 1.21.9 builds.

Maybe someone that knows more about paper internals could chime in about what this means. Do I just need to target the paper api instead of the spigot api? My server is Spigot though, so I don't want to drop compatibility with that. It's not my decision to make to drop Spigot support either. My end goal was to switch my server over to fabric once the hard fork started forcing me to choose between spigot / paper plugins.

I'd like to support both, but I know that will get harder over time.

[Tsoccerguy3]

Just include the Paper API . Its enough just to import to main java and then in your Listening code . Scenerios could be as simple as a name change or KennyTV may have found a optimized way of inputing and exporting data . Mike has a lot of experience with Dynmap and Im sure he looks at the PR's often

[jacob1]

I asked on the PaperMC discord and got this response

[8:39 PM] remapping from spigot mappings is not available on paper just yet, as we released the update before spigot was out
[8:39 PM] keep in mind that this won't be maintained forever and one day the mechanism will be dropped entirely
[8:39 PM] so you should keep separate modules for spigot v paper, or just drop spigot support entirely

So give it time, it should start working in paper in future versions.

Migrating to paper-api, and using paperweight to get Mojang mappings would definitely make it far easier to update to new versions. And it would avoid problems like this, which will be unavoidable for a certain amount of days after every new MC update. I tried for a bit to handle it (for the 1.21.9 helper) but it's not something I want to spend too much time on.

[jacob1]

Now works on Paper again, if you download the latest paper jar from today or newer
https://papermc.io/downloads/paper

[jacob1]

I updated this to 1.21.10, and renamed the directories to 1.21.10 (1.21.9 is now a dead version, quickly obsoleted by 1.21.10)