Skip to content

Add @vocab to v2 context #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Add @vocab to v2 context #1001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4caa32c
Add vocab to v2
Dec 14, 2022
6e8a86f
Update contexts/credentials/v2
OR13 Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contexts/credentials/v2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"@context": {
"@protected": true,
"@vocab": "https://www.w3.org/ns/credentials/issuer-dependent#",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... a minor point, however: I am not sure if we agreed on whether the URL for the VCDM vocabulary (not the context!) will be relocated to .../ns/credentials/. At this moment, it is still located in .../2018/.... We may want to wait merging this PR until that issue is solved. If, however, we decide not to relocate, then the URL for @vocab should be in .../2018/..., too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iherman yes... I discussed this with @msporny... I had same thought... This was the proposal that came from that... If this discussion balloons because of that choice, I suggest we revert to 2018.


"id": "@id",
"type": "@type",
Expand Down