-
Notifications
You must be signed in to change notification settings - Fork 112
Add @vocab
to v2 context
#1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @vocab
to v2 context
#1001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome path - i particularly like the private-claim
approach for labeling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, supportive of the PR as long as the following change is made (see @iherman and @dlongley's comments as to why):
The @vocab
URL should point to something that doesn't confuse these class of terms with the terms in the well defined vocabulary, so something like https://www.w3.org/ns/credentials/WORD#
(in the case where we get rid of 2018
). This will make it easy to have a separate page that caters to the intent of setting a global base vocabulary. The word we use for WORD
will need to be debated, which was entirely predictable, given that some want to use @vocab
to elicit something that's "undefined" (which is true for some definition of 'undefined'), while others want to use it for "private claims" (which is a misleading 'cause it can be used for public, but negotiated out of band, claims), while others want to use it for "issuer-dependent-vocabulary" (which is more accurate, but a mouthful).
The issue was discussed in a meeting on 2023-01-11
View the transcript2.4. Add
|
Quick question, adding this vocab, technically means that all VCs will pass JSON-LD validation? So if you do a mistake it still passes and you have to look for private-claim to verify what is unreferenced? Just asking a stupid questions after trying to follow the issue |
Yes, correct. Now, in order to detect errors, you'll have to look for terms that map to the "undefined" namespace.
Yep, you got it. |
@msporny please re-review. |
Cool cool. It sounds scary but I assume as a compromise all json ld referencers will add a warning? Or is it up to the verifiers and issuers to handle this? |
@@ -1,6 +1,7 @@ | |||
{ | |||
"@context": { | |||
"@protected": true, | |||
"@vocab": "https://www.w3.org/ns/credentials/issuer-dependent#", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... a minor point, however: I am not sure if we agreed on whether the URL for the VCDM vocabulary (not the context!) will be relocated to .../ns/credentials/
. At this moment, it is still located in .../2018/...
. We may want to wait merging this PR until that issue is solved. If, however, we decide not to relocate, then the URL for @vocab
should be in .../2018/...
, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, that is unlikely to happen on any sort of short term time frame. We're going to have to go back to the JSON-LD implementer community and see if they're interested in adding such a feature.
Undefined. :) This is why some of us were warning that putting I know that Digital Bazaar is going to have to invest in adding a feature to our JSON-LD processors that will have a callback when certain types of triples are generated now (such as those that are in the "undefined namespace") in order to be able to throw linting warnings to developers that care about the use of Make no mistake, this is a "hold your nose" compromise for some of us. :) |
The issue was discussed in a meeting on 2023-01-18
View the transcript2.2. Add
|
Normative, multiple reviews, changes requested and made, no objections, merging. |
Addresses: #953