Repository navigation
Use a temporary folder under os.tmpdir() instead of under the repo root - #822
Merged
Merged
Conversation
This was referenced Oct 8, 2026
deniak
requested changes
Oct 9, 2026
deniak
left a comment
deniak
left a comment
Member
There was a problem hiding this comment.
Thanks. This is indeed a better way to deal with these temp files.
I left 2 comments and the 'upload' folder should now be removed from .gitignore
kfranqueiro
force-pushed
the
kgf-tmpdir
branch
from
October 9, 2026 14:49
4247aea to
f9e3bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #821.
This revises spec-generator's temporary directory creation to use a directory under
os.tmpdir()rather than a subfolder of the repository. This requires some adjustment in the ReSpec generator, since it previously took advantage of being able to effectively use the same paths both to refer to the filesystem and server URLs. (While I was at it, I have also added missingpath.joinusage to hopefully make this more cross-OS-compatible.)This has the effect of resolving an interop issue with Bikeshed, where a spec with no
Repositorydefaults to the origin remote URL of any github repository that the file being processed exists within. In the case of spec-generator being deployed from a git checkout, this resulted in falling back to spec-generator's own repo URL.I have tested all upload code paths (both ReSpec and Bikeshed, both single file and tarball) manually. (
This makes me really want to add proper unit tests for those paths thoughUpdate: I have now also finally added unit tests for the file upload code paths.)