Repository navigation
Fix missing async/await in 2 respec tests - #823
Merged
Merged
Conversation
deniak
requested changes
Oct 9, 2026
deniak
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #822, I noticed some test failures that were not reported correctly. This turns out to be due to an oversight back when I added Bikeshed support, at which time I made
expectSuccessStatusasync, but a couple of ReSpec tests were still expecting it to be synchronous.Meanwhile, I noticed that the
asyncontestAllwas completely unnecessary, so I removed it.(I ran the tests locally with this fix applied when testing #822, but I could understand if we want to merge this first so that #822's tests will be validated properly in CI.)