Skip to content

Update 5.x with changes from main PR #1459 #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rerissondaniel wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

Update 5.x with changes from main PR #1459 #1460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Added

- **Input** adds aria-invalid="true" when element is in error to improve accessibility

## [5.6.2] - 2018-8-17

## [5.6.1] - 2018-08-17
Expand Down
2 changes: 1 addition & 1 deletion manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"vendor": "vtex",
"name": "styleguide",
"version": "5.6.1",
"version": "5.6.2",
"title": "VTEX Styleguide",
Copy link
Contributor Author

@rerissondaniel rerissondaniel Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed jut to be compliant with changelog, the actual version to be released in IO and NPM is 5.6.3

"description": "The VTEX Styleguide components for the Render framework",
"builders": {
Expand Down
3 changes: 3 additions & 0 deletions react/components/Input/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ class Input extends Component {
} = this.props
const { active } = this.state

const inputAriaInvalid = error || errorMessage ? 'true' : undefined

const dataAttrs = {}
for (const key of Object.keys(dataAttributes)) {
dataAttrs[`data-${key}`] = dataAttributes[key]
Expand Down Expand Up @@ -152,6 +154,7 @@ class Input extends Component {
autoCorrect={this.props.autoCorrect}
autoFocus={this.props.autoFocus}
autoSave={this.props.autoSave}
aria-invalid={inputAriaInvalid}
defaultValue={this.props.defaultValue}
inputMode={this.props.inputMode}
list={this.props.list}
Expand Down