Skip to content

Conversation

@rerissondaniel
Copy link
Contributor

Adds aria-invalid="true" when element is in error to improve accessibility

Elements have no aria attribute to identify the error status of the element to screen readers

msedge_RZwBmtiLks.mp4
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

What is the purpose of this pull request?

What problem is this solving?

Running workspace

How should this be manually tested?

Add this code in react/playground/Playground.tsx:
import React from 'react'
import PageHeader from '../PageHeader'
import Layout from '../Layout'
const Playground = () => (
  <Layout fullWidth pageHeader={<PageHeader title="Playground" />}>
    {/* Add your code here, don't forget to delete after */}
  </Layout>
)
export default Playground

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Adds aria-invalid="true" when element is in error to improve
accessibility

Elements have no aria attribute to identify the error status of the
element to screen readers

</details>

https://github.com/user-attachments/assets/994c485e-30a1-4dcc-8620-8b74addc296d

- [ ] Bug fix (a non-breaking change which fixes an issue)
- [x] New feature (a non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Requires change to documentation, which has been updated
accordingly.

---------

Co-authored-by: marcelovicentegc <[email protected]>
@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
styleguide Error Error Dec 4, 2025 5:04pm

"vendor": "vtex",
"name": "styleguide",
"version": "5.6.2",
"title": "VTEX Styleguide",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed jut to be compliant with changelog, the actual version to be released in IO and NPM is 5.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants