Add zabbix-server smsdevices configuration #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ph0B1uS if is ok for you I've opened this with you as author and me as committer, it pass all test |
bastelfreak
reviewed
Mar 10, 2025
| @@ -367,6 +367,20 @@ | |||
| it { is_expected.to contain_file('/etc/zabbix/zabbix_server.conf').without_content %r{^StartODBCPollers=1} } | |||
| end | |||
|
|
|||
| context 'with zabbix_server.conf and version 7.0' do | |||
| next if facts[:os]['name'] == 'Debian' && facts[:os]['release']['major'].to_i <= 11 | |||
There was a problem hiding this comment.
shouldn't the check be in the template iteself? If the parameter is set for an older zabbix version, the tests will pass but it will fail in production? templates/zabbix_server.conf.erb line 968 also has a version check.
There was a problem hiding this comment.
I'll remove the OS check from the file above. As for the template, if zabbix_version < 7.0 then the block won't print because of line 914 which reads:
<% if @zabbix_version.to_f >= 7.0 %>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add zabbix-server smsdevices configuration for zabbix_version >= 7.0
This Pull Request (PR) fixes the following issues
Duplicate #988
Fixes #985