Add SMSDevices in zabbix server 7+

[Ph0B1uS]

Pull Request (PR) description

Adds SMSDevices to zabbix_server.conf if defined for zabbix_version 7+

This Pull Request (PR) fixes the following issues

Fixes #985

[Valantin]

Hi, can you squash the commit and use just the verified account?

[Ph0B1uS]

Hi, can you squash the commit and use just the verified account?

I did manage to change to the verified account but it seems the squash was unsuccessful as i can still see the old commits in the repo.
I tried git rebase -i HEAD~16

Could it be that commits can only be squashed on merge? If that is the case then it will be hard to do here as all commits are in master as opposed to a feature branch.

[Valantin]

@Ph0B1uS have you replace the pick to the squash?

[Ph0B1uS]

@Ph0B1uS have you replace the pick to the squash?

Yup, i did that and changed the commit message too, then push -f but it only added to the commit count I'm afraid.

Edit: The commits will no doubt be squashed upon merging though.

[Ph0B1uS]

Alright to merge or are there any suggestions and/or corrections that needs to be implemented?

[Valantin]

Sorry but it can't be merged without the required changes, you can find here https://voxpupuli.org/docs/reviewing_pr/ the list of things to check before approve a PR

[Ph0B1uS]

Sorry but it can't be merged without the required changes, you can find here https://voxpupuli.org/docs/reviewing_pr/ the list of things to check before approve a PR

The only two points I can find in that document that needs to be rectified is:

1. the label and correct me if I'm wrong but it would appear as if I cannot do that as in am not allowed to.
2. the unfortunate commits from a non approved account.

How about I close this PR, open a new one to rectify the 2nd issue. Would that work or is there something else I've missed?

[Valantin]

try to use "git rebase -i HEAD~3" replace "pick" with "edit" for the first line "ADD..." and replace "pick" with "squash" for all the other line, than save, "git commit --amend --author "Ph0B1uS <[email protected]>" --no-edit" than "git rebase --continue"

If all is ok "git log" show you one commit than you can force push it

[Ph0B1uS]

Reopening to rerun tests

[Ph0B1uS]

Reopening to rerun tests, hopefully they work a bit better this time

[Ph0B1uS]

The failing tests has nothing to do with my code as they stem from a file which I have not touched, now what? :)

[Valantin]

Add test for the new parameter if it is on zabbix >= 7.0