fix(cli): reuse the current Node runtime for built-in tools - #2673
Merged
Conversation
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.14 MiB | 2.14 MiB | +37 B (+0.00%) |
packages/core/dist |
Directory total | 3.92 MiB | 3.92 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.07 MiB | 6.07 MiB | +37 B (+0.00%) |
vp (Linux x64) |
Binary | 11.14 MiB | 11.14 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.82 MiB | 4.82 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 32.03 MiB | 32.03 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.64 MiB | 12.64 MiB | +966 B (+0.01%) |
vp (macOS ARM64) |
Binary | 8.30 MiB | 8.30 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.20 MiB | 4.20 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 39.61 MiB | 39.61 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.96 MiB | 16.96 MiB | +774 B (+0.00%) |
vp (Windows x64) |
Binary | 9.02 MiB | 9.02 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 3.94 MiB | 3.94 MiB | +2 B (+0.00%) |
| NAPI (Windows x64) | Binary | 26.92 MiB | 26.92 MiB | +1.00 KiB (+0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.74 MiB | 10.74 MiB | +282 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.03 KiB | 7.03 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.52 MiB | 4.52 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.11 MiB | 2.11 MiB | -1 B (-0.00%) |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-reuse-cli-node-runtime-viteplus-dev.voidzero-docs.workers.dev (commit 2c98b4c)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
fengmk2
added
test: e2e
fengmk2
added this pull request to stack #2674
September 12, 2026 01:30
fengmk2
marked this pull request as ready for review
September 12, 2026 03:02
Brooooooklyn
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vp lint --lspandvp fmt --lspcan fail when an editor supplies Node butnodeis absent fromPATH.Built-in tools now use
process.execPath, passed from the JavaScript CLI through the native binding. This lets oxc-vscode#384 use VS Code's bundled Node without temporary runtime shims.Resolver tests cover eight built-in commands. A CLI snapshot starts lint and format with a renamed Node executable and no
nodeonPATH. Both language servers also passed requests under VS Code's bundled Node on macOS.The 68 Rust tests,
vp check, CLI Clippy, and snapshot comparison passed. The JavaScript suite passed 1,209 tests. One failure inresolve-core.spec.tsalso occurs on unchangedmain.