feat: support Vite+ detection and per-tool source selection - #384
Draft
fengmk2 wants to merge 15 commits into
Draft
feat: support Vite+ detection and per-tool source selection#384fengmk2 wants to merge 15 commits into
fengmk2 wants to merge 15 commits into
Conversation
liangmiQwQ
reviewed
Sep 12, 2026
fengmk2
changed the title
fengmk2
added a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Sep 12, 2026
`vp lint --lsp` and `vp fmt --lsp` can fail when an editor supplies Node but `node` is absent from `PATH`. Built-in tools now use `process.execPath`, passed from the JavaScript CLI through the native binding. This lets [oxc-vscode#384](oxc-project/oxc-vscode#384) use VS Code's bundled Node without temporary runtime shims. Resolver tests cover eight built-in commands. A CLI snapshot starts lint and format with a renamed Node executable and no `node` on `PATH`. Both language servers also passed requests under VS Code's bundled Node on macOS. The 68 Rust tests, `vp check`, CLI Clippy, and snapshot comparison passed. The JavaScript suite passed 1,209 tests. One failure in `resolve-core.spec.ts` also occurs on unchanged `main`.
|
@fengmk2 Should we automatically inject |
Author
|
@liangmiQwQ Make sense, I'll revise it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Vite+ detection RFC. The extension detects a direct
vite-plusdependency and runsvp lint --lspandvp fmt --lsp. It checks local commands before global installations.Users select each tool's source with
oxc.lint.binarySourceandoxc.fmt.binarySource. Both default toauto. Setvite-plusto skip dependency detection, oroxcto use the standalone tool. An explicitoxc.path.vpalso selects Vite+ unless the source isoxc. Explicitoxc.path.oxlintandoxc.path.oxfmtsettings keep priority.Servers follow the active project in trusted workspaces. Servers started through
vpdisable nested configuration discovery. Theoxc.useExecPathsetting supports local and global npm/pnpm entries. Running without system Node requiresvite-plus0.3.2or later.