Skip to content

fix(cli): remove oxlint and oxfmt bin wrappers - #2672

Draft
fengmk2 wants to merge 1 commit into
mainfrom
fix/remove-oxc-bin-wrappers
Draft

fix(cli): remove oxlint and oxfmt bin wrappers#2672
fengmk2 wants to merge 1 commit into
mainfrom
fix/remove-oxc-bin-wrappers

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 11, 2026

Copy link
Copy Markdown
Member

The oxlint and oxfmt bin wrappers can conflict with the upstream packages during installation. This change removes the wrappers, their bin entries, and their snapshot fixtures. It also removes the standalone tsgolint-path build entry and updates comments that refer to the wrappers.

Editors must use vp lint --lsp, vp fmt --lsp, or vp fmt --stdin-filepath.

The CLI build, scoped vp check, 33 focused tests, package checks, and editor command checks pass. Two existing snapshots fail with Vite config warnings; main produces identical output.

Related to #1557.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

CLI artifact sizes (0bb91a4)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.14 MiB 2.14 MiB -811 B (-0.04%)
packages/core/dist Directory total 3.94 MiB 3.94 MiB 0 B (0.00%)
Combined package dist Directory total 6.09 MiB 6.09 MiB -811 B (-0.01%)
vp (Linux x64) Binary 11.16 MiB 11.16 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.83 MiB 4.83 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 32.12 MiB 32.12 MiB 0 B (0.00%)
NAPI (Linux x64) gzip -9 12.71 MiB 12.71 MiB 0 B (0.00%)
vp (macOS ARM64) Binary 8.32 MiB 8.32 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 4.21 MiB 4.21 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 39.68 MiB 39.68 MiB 0 B (0.00%)
NAPI (macOS ARM64) gzip -9 17.00 MiB 17.00 MiB 0 B (0.00%)
vp (Windows x64) Binary 9.04 MiB 9.04 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 3.95 MiB 3.95 MiB +1 B (+0.00%)
NAPI (Windows x64) Binary 27.03 MiB 27.03 MiB 0 B (0.00%)
NAPI (Windows x64) gzip -9 10.80 MiB 10.80 MiB +1 B (+0.00%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.03 KiB 7.03 KiB 0 B (0.00%)
Installer (Windows x64) Binary 4.53 MiB 4.53 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.12 MiB 2.12 MiB 0 B (0.00%)

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Sep 11, 2026
@fengmk2 fengmk2 self-assigned this Sep 11, 2026
@fengmk2 fengmk2 added the preview-build Publish this PR's commits to the registry bridge as preview builds label Sep 11, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 11, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-remove-oxc-bin-wrappers-viteplus-dev.voidzero-docs.workers.dev (commit 0bb91a4)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://c81bbd3b-viteplus-dev.voidzero-docs.workers.dev 0bb91a4 2026-09-12T08:18:16.501Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://b84cfb54-viteplus-dev.voidzero-docs.workers.dev 1057b54 2026-09-12T03:18:43.383Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://76a5e14b-viteplus-dev.voidzero-docs.workers.dev 68ee71d 2026-09-12T03:15:20.491Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://6c9a6f07-viteplus-dev.voidzero-docs.workers.dev b45b2d0 2026-09-12T01:31:48.100Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://4c744d46-viteplus-dev.voidzero-docs.workers.dev 7d04a07 2026-09-11T16:14:46.473Z Visit the dashboard ↗

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Registry bridge build (b45b2d0)

This commit build is published to the registry bridge, which serves these as ordinary npm versions (every other package proxies to npmjs):

Package Version
vite-plus 0.0.0-commit.b45b2d0fabf3ebea7ad2d29044be724f6f5e8682
@voidzero-dev/vite-plus-core 0.0.0-commit.b45b2d0fabf3ebea7ad2d29044be724f6f5e8682

Install the Vite+ CLI built from this commit, then migrate a project:

# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/voidzero-dev/vite-plus/b45b2d0fabf3ebea7ad2d29044be724f6f5e8682/packages/cli/install.sh | VP_PR_VERSION=2672 VP_LEGACY_INSTALLER_URL=https://raw.githubusercontent.com/voidzero-dev/vite-plus/b45b2d0fabf3ebea7ad2d29044be724f6f5e8682/packages/cli/install-legacy.sh bash
# Windows (PowerShell)
$env:VP_PR_VERSION="2672"; $env:VP_LEGACY_INSTALLER_URL="https://raw.githubusercontent.com/voidzero-dev/vite-plus/b45b2d0fabf3ebea7ad2d29044be724f6f5e8682/packages/cli/install-legacy.ps1"; irm https://raw.githubusercontent.com/voidzero-dev/vite-plus/b45b2d0fabf3ebea7ad2d29044be724f6f5e8682/packages/cli/install.ps1 | iex

Or download the standalone Windows installer built from this commit:

Architecture Installer
x64 vp-setup-x86_64-pc-windows-msvc.exe
Arm64 vp-setup-aarch64-pc-windows-msvc.exe

GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:

.\vp-setup.exe --version "0.0.0-commit.b45b2d0fabf3ebea7ad2d29044be724f6f5e8682" --registry "https://registry-bridge.viteplus.dev/"

After installing, upgrade the current project's vite-plus to this test build with:

vp migrate

Or point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:

Package manager Registry config
npm / pnpm / Bun .npmrc: registry=https://registry-bridge.viteplus.dev/
Yarn (v2+) .yarnrc.yml: npmRegistryServer: "https://registry-bridge.viteplus.dev/"

Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):

{
  "devDependencies": {
    "vite-plus": "0.0.0-commit.b45b2d0fabf3ebea7ad2d29044be724f6f5e8682",
    "vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.b45b2d0fabf3ebea7ad2d29044be724f6f5e8682"
  }
}

@github-actions

Copy link
Copy Markdown
Contributor

🐳 Docker preview image

Built from this PR's registry bridge build:

Image Compressed size
ghcr.io/voidzero-dev/vite-plus:pr-2672 228MB
# remove any stale local copy from a previous run, then pull fresh
docker rmi ghcr.io/voidzero-dev/vite-plus:pr-2672 2>/dev/null; docker pull ghcr.io/voidzero-dev/vite-plus:pr-2672

Quick check:

docker run --rm ghcr.io/voidzero-dev/vite-plus:pr-2672 vp --version

See docs/guide/docker.md for usage.

@fengmk2
fengmk2 force-pushed the fix/remove-oxc-bin-wrappers branch from 7d04a07 to b45b2d0 Compare September 12, 2026 01:30
@fengmk2
fengmk2 changed the base branch from main to fix/reuse-cli-node-runtime September 12, 2026 01:30
@fengmk2
fengmk2 added this pull request to stack #2674 September 12, 2026 01:30
@fengmk2 fengmk2 added preview-build Publish this PR's commits to the registry bridge as preview builds and removed preview-build Publish this PR's commits to the registry bridge as preview builds labels Sep 12, 2026
Base automatically changed from fix/reuse-cli-node-runtime to main September 12, 2026 03:13
@fengmk2
fengmk2 force-pushed the fix/remove-oxc-bin-wrappers branch 2 times, most recently from 68ee71d to 1057b54 Compare September 12, 2026 03:17
@fengmk2
fengmk2 force-pushed the fix/remove-oxc-bin-wrappers branch from 1057b54 to 0bb91a4 Compare September 12, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview-build Publish this PR's commits to the registry bridge as preview builds test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant