test: improve JwtService test coverage with additional test cases.#1151
test: improve JwtService test coverage with additional test cases.#1151RomanoHeur wants to merge 2 commits into
Conversation
|
@RomanoHeur is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @RomanoHeur, thanks for contributing to Nyay Setu! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
viru0909-dev
left a comment
There was a problem hiding this comment.
Requires Changes. Please address the following issues:
- Title is not following the conventional commits format (e.g. 'feat: ...', 'fix: ...').
|
@viru0909-dev Thanks for your reply. I have updated the PR title to the conventional commit format. |
viru0909-dev
left a comment
There was a problem hiding this comment.
Review Summary
This PR has been reviewed and requires changes before it can be approved. The issues below must be resolved.
Issues to Resolve
| Result | Check | Notes |
|---|---|---|
| FAIL | Checklist | 4 checklist item(s) are still unchecked. Complete all items before submitting for review. |
| FAIL | Code Quality | 1 critical code issue(s) and 0 warning(s) found in the diff. Critical issues must be resolved before this PR can be approved. |
Passing Checks
| Result | Check | Notes |
|---|---|---|
| PASS | Title | Title format is acceptable. |
| PASS | Description | Description is complete and well-structured. |
| PASS | Issue Link | Issue is linked with a closing keyword. |
| PASS | Merge Conflicts | Conflict status is not yet computed by GitHub — skipping. |
| PASS | Branch Freshness | Branch was last updated 2.5 days ago. |
| PASS | CI / Tests | No CI checks are configured or results are not yet available. |
Code Review — Line-by-Line Findings
[ERROR] backend/nyaysetu-backend/src/test/java/com/nyaysetu/backend/service/JwtServiceTest.java — line 59
String malformedToken = "this.is.not.a.valid.jwt";
Possible hardcoded credential or secret detected.
[INFO] backend/nyaysetu-backend/src/test/java/com/nyaysetu/backend/service/JwtServiceTest.java — line 99
.setExpiration(new Date(System.currentTimeMillis() + 60000))
Large magic number detected — consider a named constant.
To proceed: push the required fixes to feat/improve-jwt-service-unit-test and the PR will be re-evaluated on the next review run.
|
@viru0909-dev Thanks for the review. I've addressed all the changes:
|
…ests
Pull Request
Description
This PR improves the test coverage of the JwtService class by adding additional unit tests and improving existing ones.
Closes #867
Type of change
Checklist: