fix: add centralized @ControllerAdvice exception handler#1147
fix: add centralized @ControllerAdvice exception handler#1147PranavAgarkar07 wants to merge 1 commit into
Conversation
|
@PranavAgarkar07 is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @PranavAgarkar07, thanks for contributing to Nyay Setu! 🎉 I have automatically:
Our workflows will now analyze your changes to classify:
Tip Ensure your PR description references the issue it resolves (e.g. Happy coding! 🚀 |
|
@viru0909-dev This PR is ready for review — CI passes, all labels applied (including gssoc:approved). Could you take a look and merge when convenient? Thanks! |
viru0909-dev
left a comment
There was a problem hiding this comment.
Requires Changes. Please address the following issues:
Backend tests failed:\n\n[ERROR] COMPILATION ERROR : [ERROR] /private/tmp/nyay-setu-working-fix/backend/nyaysetu-backend/src/main/java/com/nyaysetu/backend/exception/GlobalExceptionHandler.java:[45,95] cannot find symbol [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project nyaysetu-backend: Compilation failure [ERROR] /private/tmp/nyay-setu-working-fix/backend/nyaysetu-backend/src/main/java/com/nyaysetu/backend/exception/GlobalExceptionHandler.java:[45,95] cannot find symbol [ERROR] symbol: class AuthorizationDeniedException [ERROR] location: package org.springframework.security.authorization [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.\n
viru0909-dev
left a comment
There was a problem hiding this comment.
Review Summary
This PR has been reviewed and requires changes before it can be approved. The issues below must be resolved.
Issues to Resolve
| Result | Check | Notes |
|---|---|---|
| FAIL | Description | Description is missing: a Type of Change section; a Checklist section with checkboxes. |
| FAIL | Checklist | No checklist found in the description. |
Passing Checks
| Result | Check | Notes |
|---|---|---|
| PASS | Title | Title format is acceptable. |
| PASS | Issue Link | Issue is linked with a closing keyword. |
| PASS | Merge Conflicts | Conflict status is not yet computed by GitHub — skipping. |
| PASS | Branch Freshness | Branch was last updated 2.5 days ago. |
| PASS | CI / Tests | No CI checks are configured or results are not yet available. |
| PASS | Code Quality | No code quality issues detected in the diff. |
To proceed: push the required fixes to fix/1041-global-exception-handler and the PR will be re-evaluated on the next review run.
…rs, add EntityNotFoundException/ResourceNotFoundException
9092dc4 to
201fdd7
Compare
Description
Uncaught backend exceptions were leaking raw stack traces and internal details to API users, posing a security risk.
Changes
Type of Change
Checklist
Related Issue
Closes #1041