Skip to content

[APP-9296] Do not attempt retries when closed #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

[APP-9296] Do not attempt retries when closed #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/robot/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,8 @@ export class RobotClient extends EventDispatcher implements Robot {

this.currentRetryAttempt = attemptNumber;

// Always retry the next attempt
return true;
// Always retry the next attempt if not closed
return !this.closed;
},
};

Expand Down Expand Up @@ -634,8 +634,10 @@ export class RobotClient extends EventDispatcher implements Robot {

this.currentRetryAttempt = attemptNumber;

// Abort reconnects if the the caller specifies, otherwise retry
return !conf.reconnectAbortSignal?.abort;
const aborted = conf.reconnectAbortSignal?.abort ?? false;

// Retry if not closed or aborted
return !aborted && !this.closed;
},
};

Expand Down