[APP-9296] Do not attempt retries when closed #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheal-parks
requested review from
njooma,
dhritinaidu,
DTCurrie and
mattmacf98
DTCurrie
approved these changes
Aug 28, 2025
mattmacf98
approved these changes
Aug 28, 2025
micheal-parks
changed the title
stuqdog
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I discovered this bug after testing changes from the latest dial changes. When doing exponential backoff, we don't respect the
closedstate, causing reconnect attempts to occur even if a disconnect call has happened.This PR adds a check before each retry attempt and stops it if closed is true.