Skip to content

[APP-9815] Part 2: Viam Mobile - Displaying sensor data improvements #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[APP-9815] Part 2: Viam Mobile - Displaying sensor data improvements #457

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af43015
create scrollable
jckras Nov 25, 2025
8a54063
add no sensors readings when none
jckras Nov 25, 2025
6683290
fix and add test
jckras Nov 25, 2025
c9a61b7
Wait for async getReadings() to complete
jckras Nov 25, 2025
a722ca6
add padding
jckras Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions lib/widgets/refreshable_data_table.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,28 @@ class _ViamRefreshableDataTableState extends State<ViamRefreshableDataTable> {
Widget build(BuildContext context) {
return Column(
children: [
DataTable(
columns: const <DataColumn>[DataColumn(label: Text('Reading')), DataColumn(label: Text('Value'))],
rows: readings.keys.map((e) => DataRow(cells: [DataCell(Text(e)), DataCell(Text(readings[e].toString()))])).toList()),
if (readings.isEmpty)
const Text('No sensor readings available')
Copy link
Contributor

@martha-johnston martha-johnston Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

else
DataTable(
columns: const <DataColumn>[DataColumn(label: Text('Reading')), DataColumn(label: Text('Value'))],
rows: readings.keys
.map((e) => DataRow(cells: [
DataCell(Text(e)),
DataCell(
SizedBox(
width: MediaQuery.of(context).size.width * 0.5,
height: 120,
child: Align(
alignment: Alignment.centerLeft,
child: SingleChildScrollView(
child: Text(readings[e].toString()),
Copy link
Contributor

@martha-johnston martha-johnston Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] consider adding some padding around this so it's not so close to the divider

),
),
),
)
]))
.toList()),
if (widget.showLastRefreshed && lastRefreshed != null)
Column(children: [
const SizedBox(height: 8),
Expand Down
14 changes: 14 additions & 0 deletions test/widget_tests/refreshable_data_table_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,26 @@ void main() {
testWidgets('displays data', (tester) async {
final widget = TestableWidget(child: ViamRefreshableDataTable(getData: FakeSensor('sensor').readings));
await tester.pumpWidget(widget);
await tester.pumpAndSettle();
Copy link
Member Author

@jckras jckras Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to wait for async getReadings to complete so we added this


final dataTable = find.byType(DataTable);

expect(dataTable, findsOneWidget);
});

testWidgets('displays no sensor readings available', (tester) async {
final widget = TestableWidget(
child: ViamRefreshableDataTable(
getData: ({Map<String, dynamic>? extra}) async => <String, dynamic>{},
),
);
await tester.pumpWidget(widget);

final noSensorReadingsAvailable = find.textContaining(RegExp(r'No sensor readings available'));

expect(noSensorReadingsAvailable, findsOneWidget);
});

testWidgets('shows last refresh time', (tester) async {
final widget = TestableWidget(child: ViamRefreshableDataTable(getData: FakeSensor('sensor').readings, showLastRefreshed: true));
await tester.pumpWidget(widget);
Expand Down