[APP-9815] Part 2: Viam Mobile - Displaying sensor data improvements #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
requested review from
allisonschiang,
clintpurser,
kevin49999,
martha-johnston,
njooma and
tgritter
jckras
commented
Nov 25, 2025
| testWidgets('displays data', (tester) async { | ||
| final widget = TestableWidget(child: ViamRefreshableDataTable(getData: FakeSensor('sensor').readings)); | ||
| await tester.pumpWidget(widget); | ||
| await tester.pumpAndSettle(); |
Member
Author
There was a problem hiding this comment.
need to wait for async getReadings to complete so we added this
| columns: const <DataColumn>[DataColumn(label: Text('Reading')), DataColumn(label: Text('Value'))], | ||
| rows: readings.keys.map((e) => DataRow(cells: [DataCell(Text(e)), DataCell(Text(readings[e].toString()))])).toList()), | ||
| if (readings.isEmpty) | ||
| const Text('No sensor readings available') |
| child: Align( | ||
| alignment: Alignment.centerLeft, | ||
| child: SingleChildScrollView( | ||
| child: Text(readings[e].toString()), |
Contributor
There was a problem hiding this comment.
[nit] consider adding some padding around this so it's not so close to the divider
martha-johnston
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part 2 for this ticket: https://viam.atlassian.net/browse/APP-9815 . Part 1 can be found here: https://github.com/viamrobotics/viam-mobile/pull/360. This PR does two things:
- It makes the data cell scrollable if the text is overflowing, here is a video below:
ScreenRecording_11-25-2025.11-09-39_1.MP4
- It adds in clear text indicating when there are no sensor readings available. Previously we just displayed nothing and I believe a message indicating that there are no readings is more helpful. Here is a photo: